Skip to content

Fix MapInfo parsing for version 0x26#11

Merged
dsjoerg merged 1 commit intoggtracker:upstreamfrom
gravelweb:mini-map
Apr 19, 2016
Merged

Fix MapInfo parsing for version 0x26#11
dsjoerg merged 1 commit intoggtracker:upstreamfrom
gravelweb:mini-map

Conversation

@gravelweb
Copy link
Contributor

@gravelweb gravelweb commented Apr 18, 2016

Seems like yet another unknown byte (value=0x00) was added before the camera_* info, so I've added a single read_cstring. I'm not sure if cstring is the right thing here, but how could we possibly know without further information from blizzard, or sample data where this byte is NOT 0x00?

@dsjoerg
Copy link
Member

dsjoerg commented Apr 18, 2016

how did you figure all this out? how many maps have you tried this on?

@gravelweb
Copy link
Contributor Author

gravelweb commented Apr 18, 2016

@dsjoerg I updated dsjoerg/ggtracker#19 with this information. Not sure if I should have included it here instead. Sorry!

@dsjoerg
Copy link
Member

dsjoerg commented Apr 18, 2016

its all good 👍

@gravelweb
Copy link
Contributor Author

gravelweb commented Apr 18, 2016

Notice the extra 00 byte in the 3rd line of 1v1 hexdump below

1v1:

00000000  49 70 61 4d 26 00 00 00  7b 5c 01 00 00 00 00 00  |IpaM&...{\......|
00000010  a0 00 00 00 a0 00 00 00  01 00 00 00 01 00 00 00  |................|
00000020  00 00 01 00 00 00 00 00  00 00 44 61 72 6b 00 4b  |..........Dark.K|
00000030  6f 72 68 61 6c 43 69 74  79 45 78 32 00 06 00 00  |orhalCityEx2....|

2v2:

00000000  49 70 61 4d 22 00 00 00  11 dc 01 00 00 00 00 00  |IpaM"...........|
00000010  d8 00 00 00 d8 00 00 00  01 00 00 00 01 00 00 00  |................|
00000020  00 01 00 00 00 00 00 00  00 44 61 72 6b 00 4b 6f  |.........Dark.Ko|
00000030  72 68 61 6c 43 69 74 79  00 11 00 00 00 10 00 00  |rhalCity........|

@dsjoerg dsjoerg mentioned this pull request Apr 18, 2016
Closed
@dsjoerg
Copy link
Member

dsjoerg commented Apr 18, 2016

Parent issue is now ggtracker/ggtrackerstack#7

@dsjoerg
Copy link
Member

dsjoerg commented Apr 19, 2016

Outstanding!

@dsjoerg dsjoerg merged commit 80ea580 into ggtracker:upstream Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gravelweb @dsjoerg